[coreboot-gerrit] New patch to review for coreboot: google/gale: Turn on monotonic timer support

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri May 6 23:28:34 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14673

-gerrit

commit d529e6f240a28ed407d3e263b84c01ec2e7d8336
Author: Varadarajan Narayanan <varada at codeaurora.org>
Date:   Wed Apr 20 11:32:19 2016 +0530

    google/gale: Turn on monotonic timer support
    
    Without monotonic timer support, timer related APIs like
    timer_monotonic_get etc. are optimized out by the compiler. This
    results in timed loops to become indefinite loops
    
    	stopwatch_init_msecs_expire(...);
    	do {
    		something();
    	} while (!stopwatch_expired(...));
    
    In our specific case, loops sampling the recovery/wipeout button
    in src/mainboard/google/gale/chromeos.c:get_switch_state() turned
    into infinite loops and the boot didn't proceed.
    
    BUG=chrome-os-partner:49249
    TEST=Confirmed that the loop breaks per the specified timeout
    using the minicom's console log time stamps
    	[2016-04-11 12:34:37] recovery button pressed
    	[2016-04-11 12:34:45] wipeout requested, checking recovery
    	[2016-04-11 12:34:53] recovery requested
    BRANCH=none
    
    Change-Id: I7ed2616c50ebb28b43ad769d3105f7d4e31b1114
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: e00f888570b577849cb526220ffe6f22fe9d2ece
    Original-Change-Id: Ic0b800558ebce482da6321c30dbf732080b82941
    Original-Signed-off-by: Varadarajan Narayanan <varada at codeaurora.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/339873
    Original-Commit-Ready: David Hendricks <dhendrix at chromium.org>
    Original-Tested-by: Kan Yan <kyan at google.com>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Kan Yan <kyan at google.com>
---
 src/soc/qualcomm/ipq40xx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/soc/qualcomm/ipq40xx/Kconfig b/src/soc/qualcomm/ipq40xx/Kconfig
index 198f7aa..da01155 100644
--- a/src/soc/qualcomm/ipq40xx/Kconfig
+++ b/src/soc/qualcomm/ipq40xx/Kconfig
@@ -13,6 +13,7 @@ config SOC_QC_IPQ40XX
 	select GENERIC_GPIO_LIB
 	select SEPARATE_VERSTAGE
 	select RETURN_FROM_VERSTAGE
+	select HAVE_MONOTONIC_TIMER
 
 if SOC_QC_IPQ40XX
 



More information about the coreboot-gerrit mailing list