[coreboot-gerrit] New patch to review for coreboot: intel/pineview: Don't try to store 34 bits in 32

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri May 6 22:50:57 CEST 2016


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14639

-gerrit

commit 324f97f5fb5e15d908099508a8b7d63b686ee4b0
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Fri May 6 13:48:39 2016 -0700

    intel/pineview: Don't try to store 34 bits in 32
    
    Mask out the bit that doesn't fit in 32bits, so gcc 6.1 is happy
    
    Change-Id: I13e2b41742206b8d86b90314b80cc324c00ae637
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/northbridge/intel/pineview/raminit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index a94a2eb..e4957d2 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -822,7 +822,7 @@ static void sdram_timings(struct sysinfo *s)
 	MCHBAR8(0x26c) = (MCHBAR8(0x26c) & ~0xfa) | ((u8)(reg32 >> 24));
 	MCHBAR8(0x271) = MCHBAR8(0x271) & ~(1 << 7);
 	MCHBAR8(0x274) = MCHBAR8(0x274) & ~0x6;
-	reg32 = (u32) ((6 << 30) | (4 << 25) | (1 << 20) | (8 << 15) |
+	reg32 = (u32) (((6 & 0x03) << 30) | (4 << 25) | (1 << 20) | (8 << 15) |
 			(6 << 10) | (4 << 5) | 1);
 	MCHBAR32(0x278) = reg32;
 



More information about the coreboot-gerrit mailing list