[coreboot-gerrit] Patch merged into coreboot/master: amd/gx2 + amd/lx: Fix shift overflow issue

gerrit at coreboot.org gerrit at coreboot.org
Fri May 6 19:05:03 CEST 2016


the following patch was just integrated into master:
commit 617536e5802a10141271d342611508d139944c69
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Wed May 4 16:26:44 2016 -0700

    amd/gx2 + amd/lx: Fix shift overflow issue
    
    gcc 6.1 complains that SMM_OFFSET << 8 is larger than the register
    it is assigned to (rightly so):
    
    src/northbridge/amd/gx2/northbridgeinit.c:196:23: error: result of
        '1077936128 << 8' requires 40 bits to represent, but 'int' only
        has 32 bits [-Werror=shift-overflow=]
      msr.lo = (SMM_OFFSET << 8) & 0xfff00000;
                           ^~
    
    Change-Id: Ib0d669268202d222574abee335a6a65c8a255cc7
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-on: https://review.coreboot.org/14617
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/14617 for details.

-gerrit



More information about the coreboot-gerrit mailing list