[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: fix incorrect bdsm -> tolud memory resources

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Thu May 5 22:10:01 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14628

-gerrit

commit 62a3108af8a1949e885c7c23f34f458f2c6915d5
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu May 5 15:00:01 2016 -0500

    soc/intel/apollolake: fix incorrect bdsm -> tolud memory resources
    
    The wrong base address was being used for the region of memory
    between BDSM and TOLUD. This resulted in a very large reserved
    region starting at TOLUD instead of BDSM.
    
    Change-Id: I41d06267ffa93ea47aa059f4ddb7b9c349e51583
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/apollolake/northbridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/apollolake/northbridge.c b/src/soc/intel/apollolake/northbridge.c
index b3ae705..cc097ba 100644
--- a/src/soc/intel/apollolake/northbridge.c
+++ b/src/soc/intel/apollolake/northbridge.c
@@ -125,7 +125,7 @@ static int mc_add_dram_resources(device_t dev, int index)
 	mmio_resource(dev, index++, bgsm / KiB, (bdsm - bgsm) / KiB);
 
 	/* BDSM -> TOLUD */
-	mmio_resource(dev, index++, tolud / KiB, (tolud - bdsm) / KiB);
+	mmio_resource(dev, index++, bdsm / KiB, (tolud - bdsm) / KiB);
 
 	/* 4G -> TOUUD */
 	base_k = 4ULL*GiB / KiB;



More information about the coreboot-gerrit mailing list