[coreboot-gerrit] New patch to review for coreboot: pc80/rtc: add missing brackets in mc146818rtc.c

Iru Cai (mytbk920423@gmail.com) gerrit at coreboot.org
Wed May 4 02:32:54 CEST 2016


Iru Cai (mytbk920423 at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14603

-gerrit

commit cadf46ccb4c123e1768cb2401cac949c7a574481
Author: Iru Cai <mytbk920423 at gmail.com>
Date:   Wed May 4 08:03:15 2016 +0800

    pc80/rtc: add missing brackets in mc146818rtc.c
    
    GCC 6.1.0 complains about an misleading indentation in this file.
    
    Signed-off-by: Iru Cai <mytbk920423 at gmail.com>
    Change-Id: I80086e90febdd139606cb9baba83d4bc7a6730b1
---
 src/drivers/pc80/rtc/mc146818rtc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c
index 35dad32..a593c33 100644
--- a/src/drivers/pc80/rtc/mc146818rtc.c
+++ b/src/drivers/pc80/rtc/mc146818rtc.c
@@ -284,11 +284,12 @@ static enum cb_err set_cmos_value(unsigned long bit, unsigned long length,
 		if (byte_bit || length % 8)
 			return CB_ERR_ARG;
 
-		for (i = 0; length; i++, length -= 8, byte++)
+		for (i = 0; length; i++, length -= 8, byte++) {
 			cmos_write(ret[i], byte);
 			if (byte >= LB_CKS_RANGE_START &&
 			    byte <= LB_CKS_RANGE_END)
 				chksum_update_needed = 1;
+		}
 	}
 
 	if (chksum_update_needed) {



More information about the coreboot-gerrit mailing list