[coreboot-gerrit] Patch set updated for coreboot: nb/amd/mct_ddr3: Fix revision mask for DR processors

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Thu Mar 31 22:28:00 CEST 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14216

-gerrit

commit d1d57b14ce76131b4a7328dc4a3c530badaa770b
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Thu Mar 31 15:25:27 2016 -0500

    nb/amd/mct_ddr3: Fix revision mask for DR processors
    
    The revision mask for all DR-* series processors was incorrectly
    set to only include the DR-B revision mask.  Include all DR-*
    series prcessors in the DR_ALL revision mask.
    
    Change-Id: Iceda96aa6267b24abcbf78d39f4848d2be8053b8
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
    Found-by: Coverity, CID 1229627 (#1 of 1): Logically dead code (DEADCODE)
---
 src/northbridge/amd/amdmct/amddefs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/amd/amdmct/amddefs.h b/src/northbridge/amd/amdmct/amddefs.h
index 9193a04..bbdd2ed 100644
--- a/src/northbridge/amd/amdmct/amddefs.h
+++ b/src/northbridge/amd/amdmct/amddefs.h
@@ -67,7 +67,7 @@
 #define	AMD_DR_GT_B0		(AMD_DR_ALL & ~(AMD_DR_B0))
 #define	AMD_DR_GT_Bx		(AMD_DR_ALL & ~(AMD_DR_Ax | AMD_DR_Bx))
 #define	AMD_DR_GT_D0		((AMD_DR_Dx & ~(AMD_HY_D0)) | AMD_DR_Ex)
-#define	AMD_DR_ALL		(AMD_DR_Bx)
+#define	AMD_DR_ALL		(AMD_DR_Ax | AMD_DR_Bx | AMD_DR_Cx | AMD_DR_Dx | AMD_DR_Ex)
 #define	AMD_FAM10_ALL		(AMD_DR_ALL | AMD_RB_C2 | AMD_HY_D0 | AMD_DA_C3 | AMD_DA_C2 | AMD_RB_C3 | AMD_HY_D1 | AMD_PH_E0)
 #define AMD_FAM10_LT_D  	(AMD_FAM10_ALL & ~(AMD_HY_D0))
 #define	AMD_FAM10_GT_B0		(AMD_FAM10_ALL & ~(AMD_DR_B0))



More information about the coreboot-gerrit mailing list