[coreboot-gerrit] New patch to review for coreboot: nb/amd/mct_ddr3: Enable DIMM parity when RDIMMs installed

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Tue Mar 29 20:18:28 CEST 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14184

-gerrit

commit f8e0c0a973010b978768f7d8e63cd7ccafa7ed0a
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Tue Mar 29 13:17:02 2016 -0500

    nb/amd/mct_ddr3: Enable DIMM parity when RDIMMs installed
    
    This resolves a long-standing issue with RDIMM control word
    configuration failure, likely due to random parity failure.
    
    Change-Id: If8b8dc5b8b99f4c2fe29b3a133b064631e4693be
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index 4d9bc58..32964bd 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -5124,9 +5124,7 @@ static u8 AutoConfig_D(struct MCTStatStruc *pMCTstat,
 
 	if (Status & (1 << SB_Registered)) {
 		/* Registered DIMMs */
-		if (!is_fam15h()) {
-			DramConfigLo |= 1 << ParEn;
-		}
+		DramConfigLo |= 1 << ParEn;
 	} else {
 		/* Unbuffered DIMMs */
 		DramConfigLo |= 1 << UnBuffDimm;



More information about the coreboot-gerrit mailing list