[coreboot-gerrit] New patch to review for coreboot: payloads/Makefile.inc: Clean up Makefile

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Mar 17 21:50:05 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14131

-gerrit

commit b9c63f8f6509d1392c31aaaedfd99f6221ac70de
Author: Martin Roth <martinroth at google.com>
Date:   Wed Mar 16 10:45:35 2016 -0600

    payloads/Makefile.inc: Clean up Makefile
    
    - Instead of adding each payload to each common target, create a list
    and loop through the list for all of the payloads
    - '.phony' doesn't work - the target needs to be uppercase '.PHONY'
    
    Change-Id: I4a7712c94d0f127c2fff8cb8fada4b8132a4ab3b
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 payloads/Makefile.inc | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/payloads/Makefile.inc b/payloads/Makefile.inc
index ee3c41a..44d1d77 100644
--- a/payloads/Makefile.inc
+++ b/payloads/Makefile.inc
@@ -17,24 +17,21 @@ cbfs-files-$(CONFIG_COREINFO_SECONDARY_PAYLOAD) += img/coreinfo
 img/coreinfo-file := payloads/coreinfo/build/coreinfo.elf
 img/coreinfo-type := payload
 
+PAYLOADS_LIST=\
+payloads/coreinfo \
+payloads/libpayload \
+payloads/external/depthcharge \
+payloads/external/SeaBIOS \
+payloads/external/U-Boot \
+payloads/external/Memtest86Plus
+
 payloads/coreinfo/build/coreinfo.elf coreinfo:
 	$(MAKE) -C payloads/coreinfo defaultbuild
 
 clean-payloads:
-	$(MAKE) -C payloads/coreinfo clean
-	$(MAKE) -C payloads/libpayload clean
-	$(MAKE) -C payloads/external/depthcharge clean
-	$(MAKE) -C payloads/external/SeaBIOS clean
-	$(MAKE) -C payloads/external/U-Boot clean
-	$(MAKE) -C payloads/external/Memtest86Plus clean
-
+	$(foreach payload, $(PAYLOADS_LIST), $(MAKE) -C $(payload) clean; )
 
 distclean-payloads:
-	$(MAKE) -C payloads/coreinfo distclean
-	$(MAKE) -C payloads/libpayload distclean
-	$(MAKE) -C payloads/external/depthcharge distclean
-	$(MAKE) -C payloads/external/SeaBIOS distclean
-	$(MAKE) -C payloads/external/U-Boot distclean
-	$(MAKE) -C payloads/external/Memtest86Plus distclean
+	$(foreach payload, $(PAYLOADS_LIST), $(MAKE) -C $(payload) distclean; )
 
-.phony: clean-payloads distclean-payloads
+.PHONY: clean-payloads distclean-payloads



More information about the coreboot-gerrit mailing list