[coreboot-gerrit] New patch to review for coreboot: google/oak: Remove EC_SUSPEND_L from AP
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Mar 14 10:59:34 CET 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14087
-gerrit
commit fed41960a6a2d9f9965af6d8dace5673b04c2177
Author: Koro Chen <koro.chen at mediatek.com>
Date: Mon Mar 7 11:27:26 2016 +0800
google/oak: Remove EC_SUSPEND_L from AP
This pin is not used anymore since Rev5.
BRANCH=none
BUG=chrome-os-partner:49375
TEST=make and boot on Rev4/5
Change-Id: I3c775eb2b5e05256523bfd8be814e516944a2f90
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: a87e3babe28413bd879a2d95d4612a5b6b541419
Original-Change-Id: I87972ff8961309ecdad03639e1b6fac1da119cd7
Original-Signed-off-by: Koro Chen <koro.chen at mediatek.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/331810
Original-Commit-Ready: Yidi Lin <yidi.lin at mediatek.com>
Original-Tested-by: Yidi Lin <yidi.lin at mediatek.com>
Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
src/mainboard/google/oak/chromeos.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mainboard/google/oak/chromeos.c b/src/mainboard/google/oak/chromeos.c
index 47d816b..8ea975a 100644
--- a/src/mainboard/google/oak/chromeos.c
+++ b/src/mainboard/google/oak/chromeos.c
@@ -13,6 +13,7 @@
* GNU General Public License for more details.
*/
+#include <boardid.h>
#include <boot/coreboot_tables.h>
#include <console/console.h>
#include <ec/google/chromeec/ec.h>
@@ -30,7 +31,8 @@ void setup_chromeos_gpios(void)
gpio_input_pullup(EC_IRQ);
gpio_input_pullup(LID);
gpio_input_pullup(POWER_BUTTON);
- gpio_output(EC_SUSPEND_L, 1);
+ if (board_id() < 5)
+ gpio_output(EC_SUSPEND_L, 1);
}
void fill_lb_gpios(struct lb_gpios *gpios)
More information about the coreboot-gerrit
mailing list