[coreboot-gerrit] Patch set updated for coreboot: genbuild_h: Fix numeric comparison to remove error

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Sun Mar 13 04:33:42 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14080

-gerrit

commit 1a57c114a44f2334725cfa8f2ca71fe46398900a
Author: Martin Roth <martinroth at google.com>
Date:   Sat Mar 12 20:15:18 2016 -0700

    genbuild_h: Fix numeric comparison to remove error
    
    Change the comparison of build_timeless from -eq to =
    
    This was generating an error if BUILD_TIMELESS wasn't set:
    util/genbuild_h/genbuild_h.sh: line 27: [: : integer expression expected
    
    This wasn't causing the script to fail.
    
    Change-Id: I6a4e147ece23e83ee682d72db35be9e5d4088c78
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/genbuild_h/genbuild_h.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh
index d68b867..044d901 100755
--- a/util/genbuild_h/genbuild_h.sh
+++ b/util/genbuild_h/genbuild_h.sh
@@ -24,7 +24,7 @@ export TZ=UTC
 
 top=`dirname $0`/../..
 
-if [ "${BUILD_TIMELESS}" -eq 1 ]; then
+if [ "${BUILD_TIMELESS}" = "1" ]; then
 	GITREV=Timeless
 	TIMESOURCE="fixed"
 	DATE=0



More information about the coreboot-gerrit mailing list