[coreboot-gerrit] New patch to review for coreboot: coreinfo: Use numbers instead of letters to switch between pages

Jonathan Neuschäfer gerrit at coreboot.org
Fri Mar 11 09:01:53 CET 2016


Jonathan Neuschäfer just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14034

-gerrit

commit 2b5d2a09987dfb78f8c702fa796dc4865bab038b
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Fri Mar 11 08:50:07 2016 +0100

    coreinfo: Use numbers instead of letters to switch between pages
    
    In my opinion, the number keys (1234) are easier to use than the keys ABCD,
    because they're next to each other.
    
    Change-Id: I55bcc84d82b796311039963986216198ce37d5ee
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 payloads/coreinfo/coreinfo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c
index 41b5f12..37c840b 100644
--- a/payloads/coreinfo/coreinfo.c
+++ b/payloads/coreinfo/coreinfo.c
@@ -108,7 +108,7 @@ static void print_submenu(struct coreinfo_cat *cat)
 		return;
 
 	for (i = 0; i < cat->count; i++)
-		ptr += sprintf(ptr, "[%c: %s] ", 'A' + i,
+		ptr += sprintf(ptr, "[%c: %s] ", '1' + i,
 			       cat->modules[i]->name);
 
 	mvwprintw(menuwin, 0, 0, menu);
@@ -198,8 +198,8 @@ static void redraw_module(struct coreinfo_cat *cat)
 
 static void handle_category_key(struct coreinfo_cat *cat, int key)
 {
-	if (key >= 'a' && key <= 'z') {
-		int index = key - 'a';
+	if (key >= '1' && key <= '9') {
+		int index = key - '1';
 		if (index < cat->count) {
 			cat->cur = index;
 			redraw_module(cat);



More information about the coreboot-gerrit mailing list