[coreboot-gerrit] Patch set updated for coreboot: intel/skylake: Do not log wake source on reset

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Mar 10 17:55:15 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13991

-gerrit

commit a115ddd42a2e916b70b50f1ce79a8fc587f40fc7
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Mar 1 17:01:35 2016 -0800

    intel/skylake: Do not log wake source on reset
    
    Skip logging a wake source when just resetting without coming from
    S3 or S5 state.  This will prevent the occasional spurious event
    like PCI PME from showing up in the event log.
    
    BUG=chrome-os-partner:40635
    BRANCH=glados
    TEST=run warm reboot teset on chell and ensure no wake source is logged
    
    Change-Id: If739034dc9022b37c90b9cc849a00c604383e70f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: e7b5cc91adc3ed10df7cebd758cf8144216b9890
    Original-Change-Id: I16f4f98df8c70fd25986a8b3644334c7209fd083
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/329846
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/331173
    Original-Commit-Ready: Patrick Georgi <pgeorgi at chromium.org>
    Original-Tested-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/soc/intel/skylake/elog.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c
index bbc4147..fc3e29a 100644
--- a/src/soc/intel/skylake/elog.c
+++ b/src/soc/intel/skylake/elog.c
@@ -118,7 +118,8 @@ static void pch_log_state(void *unused)
 	pch_log_power_and_resets(ps);
 
 	/* Wake Sources */
-	pch_log_wake_source(ps);
+	if (ps->prev_sleep_state > 0)
+		pch_log_wake_source(ps);
 }
 
 BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_ENTRY, pch_log_state, NULL);



More information about the coreboot-gerrit mailing list