[coreboot-gerrit] New patch to review for coreboot: payloads/external/Makefile.inc: Don't rebuild SeaBIOS every time

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Mar 8 06:04:17 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13948

-gerrit

commit 9b5ae51326f66eea2089bf83ea03ef8bc6d496d0
Author: Martin Roth <martinroth at google.com>
Date:   Mon Mar 7 22:04:01 2016 -0700

    payloads/external/Makefile.inc: Don't rebuild SeaBIOS every time
    
    Previously, if SeaBIOS was set as the payload, it would get rebuilt
    every single time we did a build.
    
    This changes it to re-build just when there's a config change.
    
    Change-Id: Ib141f2cbf8796d449172432bb30fa4806cf90328
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 payloads/external/Makefile.inc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc
index 557de2a..bbad643 100644
--- a/payloads/external/Makefile.inc
+++ b/payloads/external/Makefile.inc
@@ -35,10 +35,11 @@ payload_revision-file := $(PAYLOAD_VERSION)
 payload_revision-type := raw
 
 SEABIOS_CC_OFFSET=$(if $(filter %ccache,$(HOSTCC)),2,1)
-seabios:
+payloads/external/SeaBIOS/seabios/out/bios.bin.elf seabios: $(top)/$(DOTCONFIG)
 	$(MAKE) -C payloads/external/SeaBIOS -f Makefile.inc \
 			HOSTCC="$(HOSTCC)" \
-			CC=$(word $(SEABIOS_CC_OFFSET),$(CC_x86_32)) CFLAGS="$(patsubst $(word $(SEABIOS_CC_OFFSET),$(CC_x86_32))%,,$(wordlist $(SEABIOS_CC_OFFSET),9999,$(CC_x86_32)))" \
+			CC=$(word $(SEABIOS_CC_OFFSET),$(CC_x86_32)) \
+			CFLAGS="$(patsubst $(word $(SEABIOS_CC_OFFSET),$(CC_x86_32))%,,$(wordlist $(SEABIOS_CC_OFFSET),9999,$(CC_x86_32)))" \
 			LD=$(word 1,$(LD_x86_32)) LDFLAGS="$(patsubst $(word 1,$(LD_x86_32))%,,$(LD_x86_32))" \
 			OBJDUMP="$(OBJDUMP_x86_32)" \
 			OBJCOPY="$(OBJCOPY_x86_32)" STRIP="$(STRIP_x86_32)" \
@@ -53,9 +54,8 @@ seabios:
 			CONFIG_TTYS0_BASE=$(CONFIG_TTYS0_BASE)
 
 payloads/external/SeaBIOS/seabios/out/vgabios.bin: seabios
-payloads/external/SeaBIOS/seabios/out/bios.bin.elf: seabios
-payloads/external/SeaBIOS/seabios/.config: seabios
-payloads/external/SeaBIOS/seabios/out/autoversion.h: seabios
+payloads/external/SeaBIOS/seabios/.config: payloads/external/SeaBIOS/seabios/out/bios.bin.elf
+payloads/external/SeaBIOS/seabios/out/autoversion.h: payloads/external/SeaBIOS/seabios/out/bios.bin.elf
 
 filo:
 	$(MAKE) -C payloads/external/FILO -f Makefile.inc \



More information about the coreboot-gerrit mailing list