[coreboot-gerrit] Patch set updated for coreboot: toolchain.inc: test IASL by version string instead of number
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Tue Mar 1 19:56:58 CET 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12847
-gerrit
commit ca42e61018f433fd1b8094c4afd01ba6c8b55a04
Author: Martin Roth <martinroth at google.com>
Date: Tue Jan 5 16:14:12 2016 -0700
toolchain.inc: test IASL by version string instead of number
Test that the coreboot toolchain version of IASL is being used by
looking for the string 'coreboot toolchain' instead of a specific
version number. While this may cause people to have to rebuild
their toolchains again now, it helps to prevent toolchain failures
when bisecting in the future.
Change-Id: I9913eeae8f29ddc3ec8c70077c05d898595eb283
Signed-off-by: Martin Roth <martinroth at google.com>
---
toolchain.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolchain.inc b/toolchain.inc
index 2289b78..c891193 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -174,7 +174,7 @@ $(foreach arch,$(sort $(foreach stage,\
# If iasl doesn't match the current coreboot version, fail the test
# TODO: Figure out if iasl is even needed for the build.
$(if $(shell if [ -n "$(IASL)" ]; then \
- $(IASL) -v 2>&1 | grep -q "$(shell util/crossgcc/buildgcc -s iasl)" || \
+ $(IASL) -v 2>&1 | grep -q "coreboot toolchain" || \
echo not-coreboot; else echo not-coreboot; fi), \
$(eval COMPILERFAIL:=1)$(eval IASLFAIL:=1)\
$(warning The coreboot toolchain version of iasl \
More information about the coreboot-gerrit
mailing list