[coreboot-gerrit] Patch merged into coreboot/master: vbnv: Do not initialize vbnv_copy in vbnv layer
gerrit at coreboot.org
gerrit at coreboot.org
Thu Jun 30 20:54:06 CEST 2016
the following patch was just integrated into master:
commit be87f73c68a81b48aec0d651a8bde52aa37f3690
Author: Furquan Shaikh <furquan at google.com>
Date: Wed Jun 29 11:26:27 2016 -0700
vbnv: Do not initialize vbnv_copy in vbnv layer
If read_vbnv finds that the vbnv_copy is not valid, it initializes it
with the correct HEADER_SIGNATURE and other attributes. However, the
vbnv copy is checked for validity and initialized at the vboot layer as
well. Since, vboot is the owner of this data, it should be the one
initializing it. Thus, if read_vbnv sees that the data is not valid,
simply reset it to all 0s and let vboot layer take care of it. This also
removes the need for additional checks to ensure that the dirty vbnv
copy is properly updated on storage.
Change-Id: I6101ac41f31f720a6e357c9c56e571d62e0f2f47
Signed-off-by: Furquan Shaikh <furquan at google.com>
Reviewed-on: https://review.coreboot.org/15498
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Julius Werner <jwerner at chromium.org>
See https://review.coreboot.org/15498 for details.
-gerrit
More information about the coreboot-gerrit
mailing list