[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: typedef global_nvs_t for consistency
Aaron Durbin (adurbin@chromium.org)
gerrit at coreboot.org
Thu Jun 30 00:37:23 CEST 2016
Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15502
-gerrit
commit ffc500fce2a6b83e8e58641bb0d9e0197da4becd
Author: Aaron Durbin <adurbin at chromium.org>
Date: Wed Jun 29 17:26:33 2016 -0500
soc/intel/apollolake: typedef global_nvs_t for consistency
Every other platform has global_nvs_t as a typedef. For some
reason apollolake didn't bother following current conventions.
Fix this omission to allow for better code sharing and consistency.
Change-Id: Id596eed517737759a64ce803c89ea2a05cbe2cce
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
src/soc/intel/apollolake/include/soc/nvs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/soc/intel/apollolake/include/soc/nvs.h b/src/soc/intel/apollolake/include/soc/nvs.h
index 3e4f432..bff949e 100644
--- a/src/soc/intel/apollolake/include/soc/nvs.h
+++ b/src/soc/intel/apollolake/include/soc/nvs.h
@@ -26,7 +26,7 @@
#include <vendorcode/google/chromeos/gnvs.h>
-struct global_nvs_t {
+typedef struct global_nvs_t {
/* Miscellaneous */
uint8_t pcnt; /* 0x00 - Processor Count */
uint8_t ppcm; /* 0x01 - Max PPC State */
@@ -42,6 +42,6 @@ struct global_nvs_t {
/* ChromeOS specific (0x100 - 0xfff) */
chromeos_acpi_t chromeos;
-} __attribute__((packed));
+} __attribute__((packed)) global_nvs_t;
#endif /* _SOC_APOLLOLAKE_NVS_H_ */
More information about the coreboot-gerrit
mailing list