New patch to review for coreboot: f15tn: enable IDSÂ printing [WIP]
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Wed Jun 22 22:00:07 CEST 2016
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15320
-gerrit
commit 928b8b9e72d748b7ae0103004f856930c0a3387c
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Wed Jun 22 22:50:10 2016 +0300
f15tn: enable IDS printing [WIP]
Change-Id: Ie5c0de6358b294160f9bf0a202161722f88059c1
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
src/Kconfig | 2 +-
src/mainboard/asus/f2a85-m/OptionsIds.h | 2 +-
src/vendorcode/amd/agesa/f15tn/Include/Ids.h | 12 ++++--------
3 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/Kconfig b/src/Kconfig
index 1cb55c9..2317da4 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1087,7 +1087,7 @@ config ENABLE_APIC_EXT_ID
config WARNINGS_ARE_ERRORS
bool
- default y
+ default n
# TODO: Remove this when all platforms are fixed.
config IASL_WARNINGS_ARE_ERRORS
diff --git a/src/mainboard/asus/f2a85-m/OptionsIds.h b/src/mainboard/asus/f2a85-m/OptionsIds.h
index b45f5a8..1a1056e 100644
--- a/src/mainboard/asus/f2a85-m/OptionsIds.h
+++ b/src/mainboard/asus/f2a85-m/OptionsIds.h
@@ -42,7 +42,7 @@
*
**/
-//#define IDSOPT_IDS_ENABLED TRUE
+#define IDSOPT_IDS_ENABLED TRUE
//#define IDSOPT_CONTROL_ENABLED TRUE
#define IDSOPT_TRACING_ENABLED TRUE
#define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE
diff --git a/src/vendorcode/amd/agesa/f15tn/Include/Ids.h b/src/vendorcode/amd/agesa/f15tn/Include/Ids.h
index b2cf9f3..7e5ab60 100644
--- a/src/vendorcode/amd/agesa/f15tn/Include/Ids.h
+++ b/src/vendorcode/amd/agesa/f15tn/Include/Ids.h
@@ -730,15 +730,11 @@ typedef enum { //vv- for debug reference only
#endif
#else
#ifdef VA_ARGS_SUPPORTED
- #if IDSOPT_C_OPTIMIZATION_DISABLED == TRUE
- #define IDS_HDT_CONSOLE(f, s, ...) AmdIdsDebugPrint (f, s, __VA_ARGS__)
- #else
+ #ifndef __GNUC__
#pragma warning(disable: 4127)
- #define IDS_HDT_CONSOLE(f, s, ...) if (f == MEM_FLOW) AmdIdsDebugPrintMem (s, __VA_ARGS__); \
- else if (f == CPU_TRACE) AmdIdsDebugPrintCpu (s, __VA_ARGS__); \
- else if (f == HT_TRACE) AmdIdsDebugPrintHt (s, __VA_ARGS__); \
- else if (f == GNB_TRACE) AmdIdsDebugPrintGnb (s, __VA_ARGS__); \
- else AmdIdsDebugPrint (f, s, __VA_ARGS__)
+ #define IDS_HDT_CONSOLE(f, s, ...)
+ #else
+ #define IDS_HDT_CONSOLE(f, s, ...) printk (BIOS_DEBUG, s, ##__VA_ARGS__);
#endif
#else
#define IDS_HDT_CONSOLE AmdIdsDebugPrint
More information about the coreboot-gerrit
mailing list