[coreboot-gerrit] Patch merged into coreboot/master: fmaptool: Make base offsets absolute in fmap_config.h
gerrit at coreboot.org
gerrit at coreboot.org
Tue Jun 21 17:15:08 CEST 2016
the following patch was just integrated into master:
commit 119dcee1dd320cc0d10c2c590f7f2563c14fb87f
Author: Julius Werner <jwerner at chromium.org>
Date: Mon Jun 20 13:21:36 2016 -0700
fmaptool: Make base offsets absolute in fmap_config.h
fmaptool generates a header file used to hardcode certain values from
the FMAP in coreboot's binaries, to avoid having to find and parse the
FMAP manually for every access. For the offset of the FMAP itself this
has already been using the absolute offset from the base of the whole
ROM, but for individual CBFS sections it only used the offset from the
immediate parent FMAP region. Since the code using it intentionally has
no knowledge of the whole section tree, this causes problems as soon as
the CBFS is a child section of something not at absolute offset 0 (as is
the case for most x86 Chromebooks).
Change-Id: If0c516083949fe5ac8cdae85e00a4461dcbdf853
Reported-by: Rolf Evers-Fischer <embedded24 at evers-fischer.de>
Signed-off-by: Julius Werner <jwerner at chromium.org>
Reviewed-on: https://review.coreboot.org/15273
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
See https://review.coreboot.org/15273 for details.
-gerrit
More information about the coreboot-gerrit
mailing list