[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Do not check FSP signatures
Alexandru Gagniuc (alexandrux.gagniuc@intel.com)
gerrit at coreboot.org
Wed Jun 8 00:38:52 CEST 2016
Alexandru Gagniuc (alexandrux.gagniuc at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15097
-gerrit
commit 00dd29c888416e1c28c6cbf3ce2d88e308df4653
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Tue Jun 7 14:37:27 2016 -0700
drivers/intel/fsp2_0: Do not check FSP signatures
The FSPM and FSPS signature fields are actually an 8-byte string, but
they are being treated as a 64-bit integers. The definition of these
integers comes from the SOC-specific headers, which create a layering
violation if used here. Simply remove the checks.
Change-Id: I8b8a131d8db21001f09173e58cc72baa4a9c195a
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/drivers/intel/fsp2_0/memory_init.c | 5 -----
src/drivers/intel/fsp2_0/silicon_init.c | 5 -----
2 files changed, 10 deletions(-)
diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c
index 45516aa..3bd1566 100644
--- a/src/drivers/intel/fsp2_0/memory_init.c
+++ b/src/drivers/intel/fsp2_0/memory_init.c
@@ -34,11 +34,6 @@ static enum fsp_status do_fsp_memory_init(void **hob_list_ptr,
upd = (struct FSPM_UPD *)(hdr->cfg_region_offset + hdr->image_base);
- if (upd->FspUpdHeader.Signature != FSPM_UPD_SIGNATURE) {
- printk(BIOS_ERR, "Invalid FSPM signature\n");
- return FSP_INCOMPATIBLE_VERSION;
- }
-
/* Copy the default values from the UPD area */
memcpy(&fspm_upd, upd, sizeof(fspm_upd));
diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c
index f1deed7..bde91da 100644
--- a/src/drivers/intel/fsp2_0/silicon_init.c
+++ b/src/drivers/intel/fsp2_0/silicon_init.c
@@ -31,11 +31,6 @@ static enum fsp_status do_silicon_init(struct fsp_header *hdr)
supd = (struct FSPS_UPD *) (hdr->cfg_region_offset + hdr->image_base);
- if (supd->FspUpdHeader.Signature != FSPS_UPD_SIGNATURE) {
- printk(BIOS_ERR, "Invalid FSPS signature\n");
- return FSP_INCOMPATIBLE_VERSION;
- }
-
memcpy(&upd, supd, sizeof(upd));
/* Give SoC/mainboard a chance to populate entries */
More information about the coreboot-gerrit
mailing list