[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp1_1: Make weak routines quiet
Leroy P Leahy (leroy.p.leahy@intel.com)
gerrit at coreboot.org
Wed Jun 1 03:52:00 CEST 2016
Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15043
-gerrit
commit d1f6755a56ef784ffb3d9bc7ca508aeb5dd30fb6
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Tue May 31 08:57:01 2016 -0700
drivers/intel/fsp1_1: Make weak routines quiet
Now that there is a better way of finding optional routines, make the
weak routines quiet so that it may be used for the optional
implementation.
TEST=Build and run on Galileo Gen2
Change-Id: Ic58c7de216394f80aee3a78dd08bd4682783be42
Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
src/drivers/intel/fsp1_1/ramstage.c | 3 ---
src/drivers/intel/fsp1_1/romstage.c | 12 ------------
2 files changed, 15 deletions(-)
diff --git a/src/drivers/intel/fsp1_1/ramstage.c b/src/drivers/intel/fsp1_1/ramstage.c
index 6e2de29..b4a6af1 100644
--- a/src/drivers/intel/fsp1_1/ramstage.c
+++ b/src/drivers/intel/fsp1_1/ramstage.c
@@ -30,7 +30,6 @@
/* SOC initialization after FSP silicon init */
__attribute__((weak)) void soc_after_silicon_init(void)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
}
/* Display SMM memory map */
@@ -209,7 +208,6 @@ void intel_silicon_init(void)
__attribute__((weak)) void mainboard_silicon_init_params(
SILICON_INIT_UPD *params)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
};
/* Display the UPD parameters for SiliconInit */
@@ -223,5 +221,4 @@ __attribute__((weak)) void soc_display_silicon_init_params(
/* Initialize the UPD parameters for SiliconInit */
__attribute__((weak)) void soc_silicon_init_params(SILICON_INIT_UPD *params)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
}
diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c
index 6584c55..c380ff7 100644
--- a/src/drivers/intel/fsp1_1/romstage.c
+++ b/src/drivers/intel/fsp1_1/romstage.c
@@ -194,14 +194,12 @@ void after_cache_as_ram_stage(void)
/* Initialize the power state */
__attribute__((weak)) struct chipset_power_state *fill_power_state(void)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
return NULL;
}
__attribute__((weak)) void mainboard_check_ec_image(
struct romstage_params *params)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
struct pei_data *pei_data;
@@ -217,8 +215,6 @@ __attribute__((weak)) void mainboard_check_ec_image(
__attribute__((weak)) void mainboard_romstage_entry(
struct romstage_params *params)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
-
post_code(0x31);
/* Initliaze memory */
@@ -360,14 +356,12 @@ __attribute__((weak)) void mainboard_add_dimm_info(
struct memory_info *mem_info,
int channel, int dimm, int index)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
}
/* Get the memory configuration data */
__attribute__((weak)) int mrc_cache_get_current_with_version(
const struct mrc_saved_data **cache, uint32_t version)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
return -1;
}
@@ -375,14 +369,12 @@ __attribute__((weak)) int mrc_cache_get_current_with_version(
__attribute__((weak)) int mrc_cache_stash_data_with_version(const void *data,
size_t size, uint32_t version)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
return -1;
}
/* Transition RAM from off or self-refresh to active */
__attribute__((weak)) void raminit(struct romstage_params *params)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
post_code(0x34);
die("ERROR - No RAM initialization specified!\n");
}
@@ -397,13 +389,11 @@ void ramstage_cache_invalid(void)
/* Display the memory configuration */
__attribute__((weak)) void report_memory_config(void)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
}
/* Choose top of stack and setup MTRRs */
__attribute__((weak)) void *setup_stack_and_mtrrs(void)
{
- printk(BIOS_ERR, "WEAK: %s/%s called\n", __FILE__, __func__);
die("ERROR - Must specify top of stack!\n");
return NULL;
}
@@ -411,11 +401,9 @@ __attribute__((weak)) void *setup_stack_and_mtrrs(void)
/* SOC initialization after RAM is enabled */
__attribute__((weak)) void soc_after_ram_init(struct romstage_params *params)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
}
/* SOC initialization before RAM is enabled */
__attribute__((weak)) void soc_pre_ram_init(struct romstage_params *params)
{
- printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
}
More information about the coreboot-gerrit
mailing list