[coreboot-gerrit] New patch to review for coreboot: util/inteltool: fix memory leak

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Jul 29 22:31:14 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15971

-gerrit

commit 2e257ba418be26d36743f20b9024ea7cff6c6a28
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Fri Jul 29 22:30:20 2016 +0200

    util/inteltool: fix memory leak
    
    A struct pci_dev was allocated but not freed.
    
    Change-Id: I6a8bbef6a118fc1f0aa7037e72c4d0dda9208f4b
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1353037
---
 util/inteltool/amb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/inteltool/amb.c b/util/inteltool/amb.c
index ca6b9cd..26bece0 100644
--- a/util/inteltool/amb.c
+++ b/util/inteltool/amb.c
@@ -439,6 +439,7 @@ int print_ambs(struct pci_dev *dev, struct pci_access *pacc)
 
 		max_channel = pci_read_byte(dev16, 0x56)/max_branch;
 		max_amb = pci_read_byte(dev16, 0x57);
+		pci_free_dev(dev16);
 		break;
 
 	default:



More information about the coreboot-gerrit mailing list