[coreboot-gerrit] Patch set updated for coreboot: intel/skylake: Enable signalling of error condition

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15964

-gerrit

commit 7896ae042e9e758815a25a188218e5bab4f8dc27
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Fri Jul 29 18:37:56 2016 +0200

    intel/skylake: Enable signalling of error condition
    
    Testing for "devfn < 0" on an unsigned doesn't work, and i2c_bus_to_devfn
    returns an int (with -1 for "error"), so use int for devfn.
    
    Change-Id: I7d1cdb6af4140f7dc322141c0c018d8418627434
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1357450, #1357449
---
 src/soc/intel/skylake/romstage/i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/skylake/romstage/i2c.c b/src/soc/intel/skylake/romstage/i2c.c
index 3d2e994..f6d1384 100644
--- a/src/soc/intel/skylake/romstage/i2c.c
+++ b/src/soc/intel/skylake/romstage/i2c.c
@@ -27,7 +27,7 @@
 
 uintptr_t lpss_i2c_base_address(unsigned bus)
 {
-	unsigned devfn;
+	int devfn;
 	pci_devfn_t dev;
 
 	/* Find device+function for this controller */
@@ -49,7 +49,7 @@ static void i2c_early_init_bus(unsigned bus)
 	const struct lpss_i2c_speed_config *sptr;
 	enum i2c_speed speed;
 	pci_devfn_t dev;
-	unsigned devfn;
+	int devfn;
 	uintptr_t base;
 	uint32_t value;
 	void *reg;