[coreboot-gerrit] New patch to review for coreboot: google/reef: fixed keyboard can't be detected on some evt boards

Kane Chen (kane.chen@intel.com) gerrit at coreboot.org
Fri Jul 29 02:34:05 CEST 2016


Kane Chen (kane.chen at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15951

-gerrit

commit 2b6c53d61460e5cd5ea8ffce75ba636825718fbd
Author: Kane Chen <kane.chen at intel.com>
Date:   Thu Jul 28 19:41:15 2016 +0800

    google/reef: fixed keyboard can't be detected on some evt boards
    
    per hw team's check and info from EDS, this pin need to be pu 20K.
    
    BUG=chrome-os-partner:55586
    Branch=none
    Test=boot ok and Quanta factory help to verify the keyboard issue is gone
    Signed-off-by: Kane Chen <kane.chen at intel.com>
    
    Change-Id: I5b0213514ce152d4e2cecdda8786925495a0f24a
---
 src/mainboard/google/reef/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/reef/gpio.h b/src/mainboard/google/reef/gpio.h
index 88f5cdc..1e88215 100644
--- a/src/mainboard/google/reef/gpio.h
+++ b/src/mainboard/google/reef/gpio.h
@@ -77,7 +77,7 @@ static const struct pad_config gpio_table[] = {
 	PAD_CFG_GPI(SMB_DATA, UP_20K, DEEP),	 /* SMB_DATA */
 
 	/* LPC */
-	PAD_CFG_NF(LPC_ILB_SERIRQ, NATIVE, DEEP, NF1), /* LPC_SERIRQ */
+	PAD_CFG_NF(LPC_ILB_SERIRQ, UP_20K, DEEP, NF1), /* LPC_SERIRQ */
 	PAD_CFG_NF(LPC_CLKOUT0, NONE, DEEP, NF1), /* LPC_CLKOUT0 */
 	PAD_CFG_GPI(LPC_CLKOUT1, UP_20K, DEEP),	 /* LPC_CLKOUT1 -- unused */
 	PAD_CFG_NF(LPC_AD0, NATIVE, DEEP, NF1),	 /* LPC_AD0 */



More information about the coreboot-gerrit mailing list