[coreboot-gerrit] New patch to review for coreboot: intel/apollolake & skylake: Move EC_SOFTWARE_SYNC to platforms

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Jul 28 20:47:44 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15939

-gerrit

commit 014905302f59ebd74f9f368b8b1148e3fe2a0447
Author: Martin Roth <martinroth at chromium.org>
Date:   Thu Jul 28 12:43:47 2016 -0600

    intel/apollolake & skylake: Move EC_SOFTWARE_SYNC to platforms
    
    Move the EC_SOFTWARE_SYNC option out of the SOC directory and into
    the platform Kconfigs, to match all the other chrome platforms.
    
    Change-Id: I7a9f220f5555a497a18b204d6dd3bdb7fdca0282
    Signed-off-by: Martin Roth <martinroth at chromium.org>
---
 src/mainboard/google/chell/Kconfig    | 1 +
 src/mainboard/google/glados/Kconfig   | 1 +
 src/mainboard/google/lars/Kconfig     | 1 +
 src/mainboard/google/reef/Kconfig     | 3 +++
 src/mainboard/intel/amenia/Kconfig    | 1 +
 src/mainboard/intel/kunimitsu/Kconfig | 1 +
 src/soc/intel/apollolake/Kconfig      | 1 -
 src/soc/intel/skylake/Kconfig         | 3 +--
 8 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/chell/Kconfig b/src/mainboard/google/chell/Kconfig
index 5ed211a..00943af 100644
--- a/src/mainboard/google/chell/Kconfig
+++ b/src/mainboard/google/chell/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 
 config CHROMEOS
 	select LID_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config DRIVERS_I2C_GENERIC
 	def_bool y
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index 3acb8e9..e1d4411 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 
 config CHROMEOS
 	select LID_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config DRIVERS_I2C_GENERIC
 	def_bool y
diff --git a/src/mainboard/google/lars/Kconfig b/src/mainboard/google/lars/Kconfig
index c602523..830c5a2 100644
--- a/src/mainboard/google/lars/Kconfig
+++ b/src/mainboard/google/lars/Kconfig
@@ -22,6 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 
 config CHROMEOS
 	select LID_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config DRIVERS_GENERIC_MAX98357A
 	default y
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig
index 5fafa8b..2cac9b7 100644
--- a/src/mainboard/google/reef/Kconfig
+++ b/src/mainboard/google/reef/Kconfig
@@ -12,6 +12,9 @@ config BOARD_SPECIFIC_OPTIONS
 	select MAINBOARD_HAS_LPC_TPM
 	select SYSTEM_TYPE_LAPTOP
 
+config CHROMEOS
+	select EC_SOFTWARE_SYNC
+
 config BOOT_MEDIA_SPI_BUS
 	int
 	default 0
diff --git a/src/mainboard/intel/amenia/Kconfig b/src/mainboard/intel/amenia/Kconfig
index 2a4189e..93aa41f 100644
--- a/src/mainboard/intel/amenia/Kconfig
+++ b/src/mainboard/intel/amenia/Kconfig
@@ -17,6 +17,7 @@ config BOARD_SPECIFIC_OPTIONS
 
 config CHROMEOS
 	select LID_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig
index d2e6951..d575aae 100644
--- a/src/mainboard/intel/kunimitsu/Kconfig
+++ b/src/mainboard/intel/kunimitsu/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 
 config CHROMEOS
 	select LID_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config DRIVERS_GENERIC_MAX98357A
 	default y
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig
index 0745679..0b4c4d7 100644
--- a/src/soc/intel/apollolake/Kconfig
+++ b/src/soc/intel/apollolake/Kconfig
@@ -59,7 +59,6 @@ config CPU_SPECIFIC_OPTIONS
 
 config CHROMEOS
 	select CHROMEOS_RAMOOPS_DYNAMIC
-	select EC_SOFTWARE_SYNC if EC_GOOGLE_CHROMEEC
 	select SEPARATE_VERSTAGE
 	select VBOOT_OPROM_MATTERS
 	select VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index bbffd17..40bad03 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -54,8 +54,7 @@ config CPU_SPECIFIC_OPTIONS
 
 config CHROMEOS
 	select CHROMEOS_RAMOOPS_DYNAMIC
-	select EC_SOFTWARE_SYNC if EC_GOOGLE_CHROMEEC
-	select VBOOT_EC_SLOW_UPDATE
+	select VBOOT_EC_SLOW_UPDATE if EC_SOFTWARE_SYNC
 	select VBOOT_OPROM_MATTERS
 	select VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT
 	select VBOOT_VBNV_CMOS



More information about the coreboot-gerrit mailing list