[coreboot-gerrit] New patch to review for coreboot: gitconfig/pre-commit: tell user how to bypass checkpatch failures

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Jul 27 20:34:27 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15920

-gerrit

commit 5997e531799da376dcd4009f769907e0f942c943
Author: Martin Roth <martinroth at chromium.org>
Date:   Wed Jul 27 12:09:26 2016 -0600

    gitconfig/pre-commit: tell user how to bypass checkpatch failures
    
    While we're working on updating checkpatch to be more friendly with
    the coreboot codebase, it's still going to be catching invalid issues
    for a while.  Since that's the case, print a message with any failure
    telling the user how to bypass the check.
    
    Hopefully this will help to keep people from just removing the
    pre-commit hook entirely.
    
    Change-Id: I43d828ba20be9e71dd025a4844c1342c66686222
    Signed-off-by: Martin Roth <martinroth at chromium.org>
---
 util/gitconfig/pre-commit | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit
index 70cd6ea..1745041 100755
--- a/util/gitconfig/pre-commit
+++ b/util/gitconfig/pre-commit
@@ -1,3 +1,3 @@
 #!/bin/sh
 %MAKE% lint-stable
-git diff --cached | util/lint/checkpatch.pl --no-signoff -q -
+git diff --cached | util/lint/checkpatch.pl --no-signoff -q - || printf "\nIf this failure is invalid, bypass it with 'git commit -n'.\n"



More information about the coreboot-gerrit mailing list