[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: Disable monitor mwait

Bora Guvendik (bora.guvendik@intel.com) gerrit at coreboot.org
Tue Jul 26 19:56:36 CEST 2016


Bora Guvendik (bora.guvendik at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15890

-gerrit

commit 62de76be88af268c38fb640a6a6a47dcb2781bde
Author: Bora Guvendik <bora.guvendik at intel.com>
Date:   Mon Jul 25 14:44:51 2016 -0700

    soc/intel/apollolake: Disable monitor mwait
    
    The monitor/mwait is broken on Apollolake. So use ACPI legacy
    mwait IO redirection as a work around
    
    BUG=chrome-os-partner:55110
    
    Change-Id: I2e1834130d9586b4310466d3549d19bf427ffe24
    Signed-off-by: Bora Guvendik <bora.guvendik at intel.com>
---
 src/soc/intel/apollolake/chip.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index c71e59a..544cd13 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -394,6 +394,9 @@ void platform_fsp_silicon_init_params_cb(struct FSPS_UPD *silupd)
 
 	silconfig->LPSS_S0ixEnable = cfg->lpss_s0ix_enable;
 
+	/* Disable monitor mwait since it is broken due to a hardware bug without a fix */
+	silconfig->MonitorMwaitEnable = 0;
+
 	/* Disable setting of EISS bit in FSP. */
 	silconfig->SpiEiss = 0;
 }



More information about the coreboot-gerrit mailing list