[coreboot-gerrit] New patch to review for coreboot: google/lars & intel/kunimitsu: Disable EC build & update

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Mon Jul 25 22:29:34 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15869

-gerrit

commit 99c64d26e720eabc900cccd2df034f61f2e30065
Author: Martin Roth <martinroth at google.com>
Date:   Mon Jul 25 14:29:14 2016 -0600

    google/lars & intel/kunimitsu: Disable EC build & update
    
    The Chrome EC codebase no longer supports the google/lars and
    intel/kunimitsu boards.  Since the coreboot.org codebase still attempts
    to build these images, we can't update to the latest Chrome EC code.
    
    To fix this, disable building the Chrome EC code for those platforms
    and disable the switch that tells the system to try to update the binary
    on the EC's spi rom.
    
    - Move the EC_SOFTWARE_SYNC Kconfig setting out of the skylake SOC, and
    into the board's Kconfig for skylake boards still supported in the
    Chrome EC build.
    - Disable building the Chrome EC code for the lars & kunimitsu boards.
    
    Change-Id: Ic4f5a1a34bb19ee31632c1ad8430c30f7154f138
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/google/chell/Kconfig    | 1 +
 src/mainboard/google/glados/Kconfig   | 1 +
 src/mainboard/google/lars/Kconfig     | 8 --------
 src/mainboard/intel/kunimitsu/Kconfig | 8 --------
 src/soc/intel/skylake/Kconfig         | 1 -
 5 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/src/mainboard/google/chell/Kconfig b/src/mainboard/google/chell/Kconfig
index 5ed211a..00943af 100644
--- a/src/mainboard/google/chell/Kconfig
+++ b/src/mainboard/google/chell/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 
 config CHROMEOS
 	select LID_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config DRIVERS_I2C_GENERIC
 	def_bool y
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index 3acb8e9..e1d4411 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 
 config CHROMEOS
 	select LID_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config DRIVERS_I2C_GENERIC
 	def_bool y
diff --git a/src/mainboard/google/lars/Kconfig b/src/mainboard/google/lars/Kconfig
index c602523..fd12104 100644
--- a/src/mainboard/google/lars/Kconfig
+++ b/src/mainboard/google/lars/Kconfig
@@ -69,14 +69,6 @@ config INCLUDE_NHLT_BLOBS
 	select NHLT_MAX98357
 	select NHLT_NAU88L25
 
-config EC_GOOGLE_CHROMEEC_BOARDNAME
-	string
-	default "lars"
-
-config EC_GOOGLE_CHROMEEC_PD_BOARDNAME
-	string
-	default "lars_pd"
-
 config GBB_HWID
 	string
 	depends on CHROMEOS
diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig
index d2e6951..7614988 100644
--- a/src/mainboard/intel/kunimitsu/Kconfig
+++ b/src/mainboard/intel/kunimitsu/Kconfig
@@ -70,14 +70,6 @@ config INCLUDE_NHLT_BLOBS
 	select NHLT_NAU88L25
 	select NHLT_SSM4567
 
-config EC_GOOGLE_CHROMEEC_BOARDNAME
-	string
-	default "kunimitsu"
-
-config EC_GOOGLE_CHROMEEC_PD_BOARDNAME
-	string
-	default "kunimitsu_pd"
-
 config GBB_HWID
 	string
 	depends on CHROMEOS
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index 4c055ea..d8401ab 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -55,7 +55,6 @@ config CHROMEOS
 	select CHROMEOS_RAMOOPS_DYNAMIC
 	select CHROMEOS_VBNV_CMOS
 	select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
-	select EC_SOFTWARE_SYNC if EC_GOOGLE_CHROMEEC
 	select VBOOT_EC_SLOW_UPDATE
 	select VBOOT_OPROM_MATTERS
 	select VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT



More information about the coreboot-gerrit mailing list