[coreboot-gerrit] Patch merged into coreboot/master: google/gru: Change UART _Static_assert() condition to #if

gerrit at coreboot.org gerrit at coreboot.org
Mon Jul 25 18:57:40 CEST 2016


the following patch was just integrated into master:
commit de110ee07d3e3c4bd0e7d65093cf58beaa5a3748
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Jul 18 18:21:25 2016 -0700

    google/gru: Change UART _Static_assert() condition to #if
    
    _Static_assert() gets evaluated even when the code path it's in is
    unreachable (e.g. inside an if (0) block). Unfortunately, Kconfigs that
    depend on a disabled Kconfig are always 0, meaning that
    CONFIG_CONSOLE_SERIAL_UART_ADDRESS on Gru cannot evaluate to UART2 when
    CONFIG_CONSOLE_SERIAL (which it depends on) is disabled. Switch the
    condition it is wrapped in to a preprocessor #if so that the
    _Static_assert() is not evaluated when building without serial support.
    
    BRANCH=None
    BUG=None
    TEST=Built and booted Kevin without serial
    
    Change-Id: I391325fcc4b7d64b4866a7fce4444e2f28365b7d
    Signed-off-by: Martin Roth <martinroth at chromium.org>
    Original-Commit-Id: f5e5cf0644154eca5b347ea381df3f6b28287524
    Original-Change-Id: I33d51d4ef09b218c14173d39a12795f0cef6bb40
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/361581
    Original-Reviewed-by: Vadim Bendebury <vbendeb at chromium.org>
    Reviewed-on: https://review.coreboot.org/15810
    Tested-by: build bot (Jenkins)
    Reviewed-by: Furquan Shaikh <furquan at google.com>


See https://review.coreboot.org/15810 for details.

-gerrit



More information about the coreboot-gerrit mailing list