[coreboot-gerrit] New patch to review for coreboot: Rename VB_SOURCE to VBOOT_SOURCE for increased clarity

Paul Kocialkowski (contact@paulk.fr) gerrit at coreboot.org
Sun Jul 24 12:27:51 CEST 2016


Paul Kocialkowski (contact at paulk.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15824

-gerrit

commit 75f8cf370ed95cfc3639b6e8b8228b7b9d780b0c
Author: Paul Kocialkowski <contact at paulk.fr>
Date:   Sun Jul 24 12:10:38 2016 +0200

    Rename VB_SOURCE to VBOOT_SOURCE for increased clarity
    
    This renames the VB_SOURCE variable to VBOOT_SOURCE in the build system,
    providing increased clarity about what it represents.
    
    Since the submodule itself is called "vboot", it makes sense to use that
    name in full instead of a very shortened (and confusing) version of it.
    
    Change-Id: Ib343b6642363665ec1205134832498a59b7c4a26
    Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
---
 Makefile.inc                                       | 4 ++--
 src/vendorcode/amd/pi/Makefile.inc                 | 2 +-
 src/vendorcode/google/chromeos/vboot2/Makefile.inc | 2 +-
 util/futility/Makefile                             | 2 +-
 util/futility/Makefile.inc                         | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 69c8843..d98fdff 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -338,8 +338,8 @@ endif
 
 CPPFLAGS_common := -Isrc -Isrc/include -Isrc/commonlib/include -I$(obj)
 CPPFLAGS_common += -Isrc/device/oprom/include
-VB_SOURCE ?= 3rdparty/vboot
-CPPFLAGS_common += -I$(VB_SOURCE)/firmware/include
+VBOOT_SOURCE ?= 3rdparty/vboot
+CPPFLAGS_common += -I$(VBOOT_SOURCE)/firmware/include
 CPPFLAGS_common += -include $(src)/include/kconfig.h
 CPPFLAGS_common += -I3rdparty
 
diff --git a/src/vendorcode/amd/pi/Makefile.inc b/src/vendorcode/amd/pi/Makefile.inc
index 4aa8906..b1cd900 100644
--- a/src/vendorcode/amd/pi/Makefile.inc
+++ b/src/vendorcode/amd/pi/Makefile.inc
@@ -62,7 +62,7 @@ AGESA_INC += -I$(src)/southbridge/amd/pi/hudson
 AGESA_INC += -I$(src)/arch/x86/include
 AGESA_INC += -I$(src)/include
 AGESA_INC += -I$(src)/commonlib/include
-AGESA_INC += -I$(VB_SOURCE)/firmware/include
+AGESA_INC += -I$(VBOOT_SOURCE)/firmware/include
 
 AGESA_CFLAGS += -march=amdfam10 -mno-3dnow -fno-zero-initialized-in-bss -fno-strict-aliasing
 CFLAGS_x86_32 += $(AGESA_CFLAGS)
diff --git a/src/vendorcode/google/chromeos/vboot2/Makefile.inc b/src/vendorcode/google/chromeos/vboot2/Makefile.inc
index b0a3c12..87dd68c 100644
--- a/src/vendorcode/google/chromeos/vboot2/Makefile.inc
+++ b/src/vendorcode/google/chromeos/vboot2/Makefile.inc
@@ -64,7 +64,7 @@ $(VB2_LIB): $(obj)/config.h
 	$(Q)FIRMWARE_ARCH=$(VB_FIRMWARE_ARCH) \
 	CC="$(CC_verstage)" \
 	CFLAGS="$(VBOOT_CFLAGS)" VBOOT2="y" \
-	$(MAKE) -C $(VB_SOURCE) \
+	$(MAKE) -C $(VBOOT_SOURCE) \
 		BUILD=$(abspath $(dir $(VB2_LIB))) \
 		V=$(V) \
 		fwlib20
diff --git a/util/futility/Makefile b/util/futility/Makefile
index f00e2eb..36f2b31 100644
--- a/util/futility/Makefile
+++ b/util/futility/Makefile
@@ -2,7 +2,7 @@ top ?= $(abspath ../..)
 objutil ?= $(top)/util
 
 HOSTCC ?= $(CC)
-VB_SOURCE ?= $(top)/3rdparty/vboot
+VBOOT_SOURCE ?= $(top)/3rdparty/vboot
 
 .PHONY: all
 all: $(objutil)/futility/futility
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc
index d37be4b..782953e 100644
--- a/util/futility/Makefile.inc
+++ b/util/futility/Makefile.inc
@@ -2,7 +2,7 @@ additional-dirs += $(objutil)/futility
 
 $(objutil)/futility/build/futility/futility:
 	@printf "    MAKE       $(subst $(objutil)/,,$(@))\n"
-	unset CFLAGS LDFLAGS; $(MAKE) -C $(VB_SOURCE) \
+	unset CFLAGS LDFLAGS; $(MAKE) -C $(VBOOT_SOURCE) \
 		BUILD=$(abspath $@/../..) \
 		CC="$(HOSTCC)" \
 		V=$(V) \



More information about the coreboot-gerrit mailing list