[coreboot-gerrit] Patch set updated for coreboot: apollolake: Move CHROMEOS config to SoC
Furquan Shaikh (furquan@google.com)
gerrit at coreboot.org
Sun Jul 24 06:20:57 CEST 2016
Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15821
-gerrit
commit 64894284b7a9b5e5e10cdd6b91ba7d6747302672
Author: Furquan Shaikh <furquan at google.com>
Date: Fri Jul 22 12:57:51 2016 -0700
apollolake: Move CHROMEOS config to SoC
All the mainboards share the same config options for CHROMEOS. Instead
of duplicating those in every mainboard, move the CHROMEOS config to SoC
and make it dependent on MAINBOARD_HAS_CHROMEOS.
BUG=chrome-os-partner:55431
Change-Id: I2d54ff6beac9fca7596a8f104e3c1447cada5c05
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
src/mainboard/google/reef/Kconfig | 14 +++-----------
src/mainboard/intel/amenia/Kconfig | 4 +---
src/soc/intel/apollolake/Kconfig | 11 +++++++++++
3 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig
index 42019c7..17b0b62 100644
--- a/src/mainboard/google/reef/Kconfig
+++ b/src/mainboard/google/reef/Kconfig
@@ -12,21 +12,13 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_LPC_TPM
select SYSTEM_TYPE_LAPTOP
+config CHROMEOS
+ select LID_SWITCH
+
config BOOT_MEDIA_SPI_BUS
int
default 0
-config CHROMEOS
- select CHROMEOS_RAMOOPS_DYNAMIC
- select CHROMEOS_VBNV_CMOS
- select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
- select EC_SOFTWARE_SYNC
- select LID_SWITCH
- select SEPARATE_VERSTAGE
- select VBOOT_OPROM_MATTERS
- select VBOOT_STARTS_IN_BOOTBLOCK
- select VIRTUAL_DEV_SWITCH
-
config DRIVERS_I2C_DA7219
default y
diff --git a/src/mainboard/intel/amenia/Kconfig b/src/mainboard/intel/amenia/Kconfig
index dd04a6f..2a4189e 100644
--- a/src/mainboard/intel/amenia/Kconfig
+++ b/src/mainboard/intel/amenia/Kconfig
@@ -16,9 +16,7 @@ config BOARD_SPECIFIC_OPTIONS
select TPM_ON_FAST_SPI
config CHROMEOS
- bool
- default y
- select VIRTUAL_DEV_SWITCH
+ select LID_SWITCH
config MAINBOARD_DIR
string
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig
index d36fc06..25a256f 100644
--- a/src/soc/intel/apollolake/Kconfig
+++ b/src/soc/intel/apollolake/Kconfig
@@ -57,6 +57,17 @@ config CPU_SPECIFIC_OPTIONS
select SOC_INTEL_COMMON_GFX_OPREGION
select ADD_VBT_DATA_FILE
+config CHROMEOS
+ depends on MAINBOARD_HAS_CHROMEOS
+ select CHROMEOS_RAMOOPS_DYNAMIC
+ select CHROMEOS_VBNV_CMOS
+ select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
+ select EC_SOFTWARE_SYNC if EC_GOOGLE_CHROMEEC
+ select SEPARATE_VERSTAGE
+ select VBOOT_OPROM_MATTERS
+ select VBOOT_STARTS_IN_BOOTBLOCK
+ select VIRTUAL_DEV_SWITCH
+
config TPM_ON_FAST_SPI
bool
default n
More information about the coreboot-gerrit
mailing list