[coreboot-gerrit] New patch to review for coreboot: buildgcc: quote command substitutions

Idwer Vollering (vidwer@gmail.com) gerrit at coreboot.org
Sun Jul 24 02:18:24 CEST 2016


Idwer Vollering (vidwer at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15820

-gerrit

commit 3097f82e996d56f57db1751c90c32d9d9c405967
Author: Idwer Vollering <vidwer at gmail.com>
Date:   Sun Jul 24 02:10:19 2016 +0200

    buildgcc: quote command substitutions
    
    There are shells where the result of a command substitution is subject to word splitting (e.g. dash where assigning a value inside an export statement).
    
    Change-Id: I70a5bc124af7ee621da2bdb4777f3eaba8adafbb
    Signed-off-by: Idwer Vollering <vidwer at gmail.com>
    Signed-off-by: Nico Huber <nico.h at gmx.de>
---
 util/crossgcc/buildgcc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 49f6f4c..3b3eba9 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -435,8 +435,8 @@ have_hostcflags_from_gmp() {
 set_hostcflags_from_gmp() {
 	# Now set CFLAGS to match GMP CFLAGS but strip out -pedantic
 	# as GCC 4.6.x fails if it's there.
-	export HOSTCFLAGS=$(grep __GMP_CFLAGS $DESTDIR$TARGETDIR/include/gmp.h |cut -d\" -f2 |\
-	    sed s,-pedantic,,)
+	export HOSTCFLAGS="$(grep __GMP_CFLAGS $DESTDIR$TARGETDIR/include/gmp.h |cut -d\" -f2 |\
+	    sed s,-pedantic,,)"
 }
 
 build_GMP() {



More information about the coreboot-gerrit mailing list