[coreboot-gerrit] Patch merged into coreboot/master: buildgcc: Never set GMP CFLAGS manually in order to get the right flags

gerrit at coreboot.org gerrit at coreboot.org
Thu Jul 21 11:49:29 CEST 2016


the following patch was just integrated into master:
commit 7899db23557cc5eacadf42b53eaad5ebc0fe0c0e
Author: Paul Kocialkowski <contact at paulk.fr>
Date:   Fri Jun 17 21:41:00 2016 -0700

    buildgcc: Never set GMP CFLAGS manually in order to get the right flags
    
    When no CFLAGS are explicitly provided to it, the GMP configure script
    will figure out the best optimization flags to use on its own. In
    particular, it will setup the march, mfpu and mtune flags based on
    hardware detection.
    
    However, when CFLAGS are provided, they are used as-is and such
    detection doesn't happen. When the march, mfpu and mtune flags are not
    provided (which happens when GMP wasn't built already), not only will
    related optimizations be disabled, but some code might not build because
    of missing support. This happens with NEON instructions on ARMv7 hosts.
    
    Thus, it is better not to set CFLAGS and leave it up to the GMP
    configure script to get them right and still reuse those later.
    
    Change-Id: I6ffcbac1298523d1b8ddf29a8bca1b00298828a7
    Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
    Reviewed-on: https://review.coreboot.org/15452
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nico Huber <nico.h at gmx.de>


See https://review.coreboot.org/15452 for details.

-gerrit



More information about the coreboot-gerrit mailing list