[coreboot-gerrit] Patch set updated for coreboot: soc/intel/quark: Fix legacy GPIO reads

[Lee Leahy (leroy.p.leahy@intel.com)]

Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15732

-gerrit

commit 2432f72ee5da3be352793e10c31958e98f8f7fe3
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Mon Jul 18 10:39:55 2016 -0700

    soc/intel/quark: Fix legacy GPIO reads
    
    Add missing break to LEG_GPIO_REGS case to return the correct value for
    legacy GPIO reads.  Fixes coverity issue CID 1357460.
    
    Found by Coverity, Fixes:
    * CID 1357460 (#1 of 1): Unused value (UNUSED_VALUE)
      returned_value: Assigning value from reg_legacy_gpio_read(step->reg)
      to value here, but that stored value is overwritten before it can be
      used.
    
      value_overwrite: Overwriting previous write to value with value from
      reg_pcie_afe_read(step->reg).
    
    TEST=Build and run on Galileo Gen2.
    
    Change-Id: I6c52e8801a32f510ac94276fe0c097850cbfde57
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/reg_access.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/soc/intel/quark/reg_access.c b/src/soc/intel/quark/reg_access.c
index c468807..25a52ff 100644
--- a/src/soc/intel/quark/reg_access.c
+++ b/src/soc/intel/quark/reg_access.c
@@ -251,6 +251,7 @@ static uint64_t reg_read(struct reg_script_context *ctx)
 	case LEG_GPIO_REGS:
 		ctx->display_prefix = "Legacy GPIO";
 		value = reg_legacy_gpio_read(step->reg);
+		break;
 
 	case PCIE_AFE_REGS:
 		ctx->display_prefix = "PCIe AFE";