[coreboot-gerrit] Patch merged into coreboot/master: drivers/intel/fsp2_0: fix hand-off-block types and size

gerrit at coreboot.org gerrit at coreboot.org
Tue Jul 19 20:14:16 CEST 2016


the following patch was just integrated into master:
commit a3a06aeac5879f36f35bb462616e29fbe4a177f9
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Sat Jul 16 17:29:47 2016 -0500

    drivers/intel/fsp2_0: fix hand-off-block types and size
    
    The gcc compiler treats sizeof(void) == 1. Therefore requesting
    a 1 byte reservation in cbmem and writing a pointer into the
    buffer returned is wrong. Fix the size of the request to be
    32-bits because FSP 2.0 is in 32-bit space by definition. Also,
    since the access to the field happens across stage boundaries
    it's important to ensure fixed widths are used in case a later
    stage has a different pointer bit width.
    
    BUG=chrome-os-partner:52679
    
    Change-Id: Ib4efc7d5369d44a995318aac6c4a7cfdc73e4a8c
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/15737
    Reviewed-by: Furquan Shaikh <furquan at google.com>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/15737 for details.

-gerrit



More information about the coreboot-gerrit mailing list