[coreboot-gerrit] New patch to review for coreboot: Revert "AMD k8 fam10: Drop excessive spinlock initialization"

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Jul 19 19:49:35 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15752

-gerrit

commit 1361dcff45f2a967cb449bedc9c073d61aa463f6
Author: Martin Roth <martinroth at google.com>
Date:   Tue Jul 19 11:45:20 2016 -0600

    Revert "AMD k8 fam10: Drop excessive spinlock initialization"
    
    This reverts commit 70cd54310b98f422b7d66a0e0932d53edec40bb7.
    
    This commit is breaking the ASUS KGPE-D16 board.  Unfortunately
    this board was offline when the commit was tested, so it wasn't
    picked up when the patch was tested initially.
    
    Change-Id: Ib318d28ab7ed58791447e271b973104ac60eff8b
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/cpu/amd/car/post_cache_as_ram.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/cpu/amd/car/post_cache_as_ram.c b/src/cpu/amd/car/post_cache_as_ram.c
index 9cf3c6e..b5faa77 100644
--- a/src/cpu/amd/car/post_cache_as_ram.c
+++ b/src/cpu/amd/car/post_cache_as_ram.c
@@ -94,6 +94,13 @@ static void prepare_ramstage_region(int s3resume)
 		memset_((void*)0, 0, CONFIG_RAMTOP - backup_top);
 	}
 
+#if IS_ENABLED(CONFIG_HAVE_ROMSTAGE_CONSOLE_SPINLOCK)
+	initialize_romstage_console_lock();
+#endif
+#if IS_ENABLED(CONFIG_HAVE_ROMSTAGE_NVRAM_CBFS_SPINLOCK)
+	initialize_romstage_nvram_cbfs_lock();
+#endif
+
 	print_car_debug(" Done\n");
 }
 



More information about the coreboot-gerrit mailing list