[coreboot-gerrit] New patch to review for coreboot: rockchip/rk3399: Remove unused variable
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Mon Jul 18 20:39:12 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15749
-gerrit
commit 6e30a5ab306a0cbf167fb754363d61e9800100ab
Author: Martin Roth <martinroth at chromium.org>
Date: Mon Jul 18 10:56:12 2016 -0600
rockchip/rk3399: Remove unused variable
The 'speed' variable isn't being used after refactoring.
Change-Id: Id27a920c61b2bba18d391a7bfefe570235402dec
Signed-off-by: Martin Roth <martinroth at chromium.org>
---
src/soc/rockchip/rk3399/sdram.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/src/soc/rockchip/rk3399/sdram.c b/src/soc/rockchip/rk3399/sdram.c
index 5ef6479..293a0f2 100644
--- a/src/soc/rockchip/rk3399/sdram.c
+++ b/src/soc/rockchip/rk3399/sdram.c
@@ -313,7 +313,6 @@ static void phy_io_config(u32 channel,
u32 *denali_phy = rk3399_ddr_publ[channel]->denali_phy;
u32 vref_mode, vref_value;
u32 mode_sel = 0;
- u32 speed;
u32 reg_value;
/* vref setting */
@@ -363,15 +362,6 @@ static void phy_io_config(u32 channel,
/* PHY_939 PHY_PAD_CS_DRIVE */
clrsetbits_le32(&denali_phy[939], 0x7 << 14, mode_sel << 14);
- if (sdram_params->ddr_freq < 400 * MHz)
- speed = 0x0;
- else if (sdram_params->ddr_freq < 800 * MHz)
- speed = 0x1;
- else if (sdram_params->ddr_freq < 1200 * MHz)
- speed = 0x2;
- else
- die("Halting: Unknown DRAM speed.\n");
-
/* PHY_924 PHY_PAD_FDBK_DRIVE */
clrsetbits_le32(&denali_phy[924], 0x3 << 21, mode_sel << 21);
/* PHY_926 PHY_PAD_DATA_DRIVE */
More information about the coreboot-gerrit
mailing list