[coreboot-gerrit] New patch to review for coreboot: arch/riscv: Remove enter_supervisor

Jonathan Neuschäfer (j.neuschaefer@gmx.net) gerrit at coreboot.org
Mon Jul 18 17:59:34 CEST 2016


Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15729

-gerrit

commit d1a38d30a4cb3b4ae9c1f5d57e962e3a2a8a7bdd
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Mon Jul 18 17:56:59 2016 +0200

    arch/riscv: Remove enter_supervisor
    
    This function is unused since coreboot starts payloads in machine mode,
    and it uses the obsolete eret instruction.
    
    Change-Id: I98d7d0de5a3959821c21a0ba4319efb610fdefde
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 src/arch/riscv/include/vm.h     | 1 -
 src/arch/riscv/virtual_memory.c | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h
index f9ffc40..5bf03c7 100644
--- a/src/arch/riscv/include/vm.h
+++ b/src/arch/riscv/include/vm.h
@@ -57,7 +57,6 @@
 typedef uintptr_t pte_t;
 extern pte_t* root_page_table;
 
-void enter_supervisor(void);
 void initVirtualMemory(void);
 
 size_t pte_ppn(pte_t pte);
diff --git a/src/arch/riscv/virtual_memory.c b/src/arch/riscv/virtual_memory.c
index 64ea2b1..a7a81fb 100644
--- a/src/arch/riscv/virtual_memory.c
+++ b/src/arch/riscv/virtual_memory.c
@@ -29,11 +29,6 @@ void walk_page_table(void) {
 	printk(BIOS_DEBUG, "root_page_table: %p\n", t);
 }
 
-void enter_supervisor(void) {
-	// enter supervisor mode
-	asm volatile("la t0, 1f; csrw mepc, t0; eret; 1:" ::: "t0");
-}
-
 void flush_tlb(void)
 {
 	asm volatile("sfence.vm");



More information about the coreboot-gerrit mailing list