[coreboot-gerrit] Patch set updated for coreboot: acpi: Change API called to write the name for ACPI_DP_TYPE_CHILD

HARSHAPRIYA N (harshapriya.n@intel.com) gerrit at coreboot.org
Sat Jul 16 21:43:45 CEST 2016


HARSHAPRIYA N (harshapriya.n at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15724

-gerrit

commit 0cb71a1bf5e82f02506ed5c1db7522da2bb5ff96
Author: Harsha Priya <harshapriya.n at intel.com>
Date:   Fri Jul 15 17:31:43 2016 -0700

    acpi: Change API called to write the name for ACPI_DP_TYPE_CHILD
    
    The API called to write the name of the child table in the
    dp entry (type ACPI_DP_TYPE_CHILD) was not including the
    quotes, e.g., it was DAAD and not "DAAD". Thus, the kernel driver
    did not get the right information from SSDT.
    
    Change the API to acpigen_write_string() to fix the issue.
    
    Signed-off-by: Harsha Priya <harshapriya.n at intel.com>
    Change-Id: Id33ad29e637bf1fe6b02e8a4b0fd9e220e8984e7
---
 src/arch/x86/acpi_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c
index ce31dc8..2982999 100644
--- a/src/arch/x86/acpi_device.c
+++ b/src/arch/x86/acpi_device.c
@@ -498,10 +498,10 @@ static void acpi_dp_write_value(const struct acpi_dp *prop)
 		acpigen_write_integer(prop->integer);
 		break;
 	case ACPI_DP_TYPE_STRING:
+	case ACPI_DP_TYPE_CHILD:
 		acpigen_write_string(prop->string);
 		break;
 	case ACPI_DP_TYPE_REFERENCE:
-	case ACPI_DP_TYPE_CHILD:
 		acpigen_emit_namestring(prop->string);
 		break;
 	case ACPI_DP_TYPE_ARRAY:



More information about the coreboot-gerrit mailing list