[coreboot-gerrit] New patch to review for coreboot: acpi: Change API called to write the name for ACPI_DP_TYPE_CHILD

HARSHAPRIYA N (harshapriya.n@intel.com) gerrit at coreboot.org
Sat Jul 16 02:43:18 CEST 2016


HARSHAPRIYA N (harshapriya.n at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15724

-gerrit

commit 17bcf8565f94b4d4bdef553c93a1fa0ee34c95eb
Author: Harsha Priya <harshapriya.n at intel.com>
Date:   Fri Jul 15 17:31:43 2016 -0700

    acpi: Change API called to write the name for ACPI_DP_TYPE_CHILD
    
    The API called to write the name of the child table in the
    dp entry (type ACPI_DP_TYPE_CHILD) was not including the
    quotes (ex:it was DAAD and not "DAAD"). Thus, the kernel driver
    did not get the right information from SSDT.
    
    Change the API to acpigen_write_string() to fix the issue
    
    Signed-off-by: Harsha Priya <harshapriya.n at intel.com>
    Change-Id: Id33ad29e637bf1fe6b02e8a4b0fd9e220e8984e7
---
 src/arch/x86/acpi_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c
index ce31dc8..0de342b 100644
--- a/src/arch/x86/acpi_device.c
+++ b/src/arch/x86/acpi_device.c
@@ -502,7 +502,7 @@ static void acpi_dp_write_value(const struct acpi_dp *prop)
 		break;
 	case ACPI_DP_TYPE_REFERENCE:
 	case ACPI_DP_TYPE_CHILD:
-		acpigen_emit_namestring(prop->string);
+		acpigen_write_string(prop->string);
 		break;
 	case ACPI_DP_TYPE_ARRAY:
 		acpi_dp_write_array(prop->array);



More information about the coreboot-gerrit mailing list