[coreboot-gerrit] Patch set updated for coreboot: tpm2_tlcl: Use signed integer for tpm2_marshal_command return value
Duncan Laurie (dlaurie@chromium.org)
gerrit at coreboot.org
Fri Jul 15 14:04:11 CEST 2016
Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15717
-gerrit
commit 29158e57ccc81dd722082d73486b31e5108effee
Author: Duncan Laurie <dlaurie at google.com>
Date: Fri Jul 15 04:51:45 2016 -0700
tpm2_tlcl: Use signed integer for tpm2_marshal_command return value
The tpm2_marshal_command() function returns a negative value on error,
so we must use a signed type for the return value.
This was found by the coverity scan:
https://scan.coverity.com/projects/coreboot?tab=overview
Change-Id: I56d2ce7d52b9b70e43378c13c66b55ac2948f218
Signed-off-by: Duncan Laurie <dlaurie at google.com>
---
src/lib/tpm2_tlcl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/tpm2_tlcl.c b/src/lib/tpm2_tlcl.c
index d9f9d37..4ac112a 100644
--- a/src/lib/tpm2_tlcl.c
+++ b/src/lib/tpm2_tlcl.c
@@ -21,7 +21,8 @@
static void *tpm_process_command(TPM_CC command, void *command_body)
{
- size_t out_size, in_size;
+ ssize_t out_size;
+ size_t in_size;
/* Command/response buffer. */
static uint8_t cr_buffer[TPM_BUFFER_SIZE];
More information about the coreboot-gerrit
mailing list