[coreboot-gerrit] New patch to review for coreboot: intel/pineview: Do not use scratchpad register for ACPI S3

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15715

-gerrit

commit 3e6cad5d5761b470d23782df0fea9e68c855c4b0
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jul 15 13:51:22 2016 +0300

    intel/pineview: Do not use scratchpad register for ACPI S3
    
    If S3 support was implemented for this platform later on, use
    romstage handoff structure instead.
    
    Change-Id: Ib0cf3ad41753baee26354c5ed19294048e7fb533
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/intel/pineview/early_init.c  |  1 -
 src/northbridge/intel/pineview/northbridge.c | 16 ----------------
 2 files changed, 17 deletions(-)

diff --git a/src/northbridge/intel/pineview/early_init.c b/src/northbridge/intel/pineview/early_init.c
index 4e968c2..842ffa1 100644
--- a/src/northbridge/intel/pineview/early_init.c
+++ b/src/northbridge/intel/pineview/early_init.c
@@ -206,7 +206,6 @@ static void pineview_setup_bars(void)
 	pci_write_config8(D0F0, PAM5, 0x33);
 	pci_write_config8(D0F0, PAM6, 0x33);
 
-	pci_write_config32(D0F0, SKPAD, SKPAD_NORMAL_BOOT_MAGIC);
 	printk(BIOS_DEBUG, " done.\n");
 }
 
diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c
index c7cfec2..bf35731 100644
--- a/src/northbridge/intel/pineview/northbridge.c
+++ b/src/northbridge/intel/pineview/northbridge.c
@@ -177,22 +177,6 @@ static void enable_dev(device_t dev)
 	/* Set the operations if it is a special bus type */
 	if (dev->path.type == DEVICE_PATH_DOMAIN) {
 		dev->ops = &pci_domain_ops;
-#if CONFIG_HAVE_ACPI_RESUME
-		switch (pci_read_config32(dev_find_slot(0, PCI_DEVFN(0, 0)), /*D0F0_SKPD*/0xdc)) {
-		case SKPAD_NORMAL_BOOT_MAGIC:
-			printk(BIOS_DEBUG, "Normal boot.\n");
-			acpi_slp_type=0;
-			break;
-		case SKPAD_ACPI_S3_MAGIC:
-			printk(BIOS_DEBUG, "S3 Resume.\n");
-			acpi_slp_type=3;
-			break;
-		default:
-			printk(BIOS_DEBUG, "Unknown boot method, assuming normal.\n");
-			acpi_slp_type=0;
-			break;
-		}
-#endif
 	} else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) {
 		dev->ops = &cpu_bus_ops;
 	}