[coreboot-gerrit] Patch set updated for coreboot: rockchip/rk3399: Remove empty function in sdram.c

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Jul 14 20:03:31 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15657

-gerrit

commit bc51cc5de5e904635dc3fb13f4bc11686f5372e3
Author: Derek Basehore <dbasehore at chromium.org>
Date:   Mon Jun 20 14:06:42 2016 -0700

    rockchip/rk3399: Remove empty function in sdram.c
    
    This removes an empty function for sdram training. If it's needed
    later, we can always add it back.
    
    BRANCH=none
    BUG=none
    TEST=build and boot firmware for kevin/gru
    
    Change-Id: Id526ef86cf5044894a1a736cc39f10d32f49c072
    Signed-off-by: Martin Roth <martinroth at chromium.org>
    Original-Commit-Id: 3e93461b96bfadc08bf0b46cf99052d9cdffa422
    Original-Change-Id: I6bf77d2f81719c68cd78722c3fe9ae547ea1e79c
    Original-Signed-off-by: Derek Basehore <dbasehore at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/354164
    Original-Reviewed-by: Martin Roth <martinroth at chromium.org>
---
 src/soc/rockchip/rk3399/sdram.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/soc/rockchip/rk3399/sdram.c b/src/soc/rockchip/rk3399/sdram.c
index 47fa098..5ef6479 100644
--- a/src/soc/rockchip/rk3399/sdram.c
+++ b/src/soc/rockchip/rk3399/sdram.c
@@ -111,10 +111,6 @@ static void copy_to_reg(u32 *dest, const u32 *src, u32 n)
 	}
 }
 
-static void ddr_move_to_access_state(u32 channel)
-{
-}
-
 static void phy_dll_bypass_set(u32 channel,
 	struct rk3399_ddr_publ_regs *ddr_publ_regs, u32 freq)
 {
@@ -955,7 +951,6 @@ void sdram_init(const struct rk3399_sdram_params *sdram_params)
 
 		set_ddrconfig(sdram_params, channel,
 			      sdram_params->ch[channel].ddrconfig);
-		ddr_move_to_access_state(channel);
 	}
 	dram_all_config(sdram_params);
 	printk(BIOS_INFO, "Finish SDRAM initialization...\n");



More information about the coreboot-gerrit mailing list