[coreboot-gerrit] Patch set updated for coreboot: AMD binaryPI: Use common romstage ram stack

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Jul 14 09:41:59 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15575

-gerrit

commit d9a874c91a5af72b6944096cef5632e0d69fc41c
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Jun 18 17:55:08 2016 +0300

    AMD binaryPI: Use common romstage ram stack
    
    Note that no binaryPI board has HAVE_ACPI_RESUME.
    
    Change-Id: I52d0bd7dac86822242400f68f6dc202f02d6e0f1
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/amd/pi/s3_resume.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/cpu/amd/pi/s3_resume.c b/src/cpu/amd/pi/s3_resume.c
index 830d174..6426c97 100644
--- a/src/cpu/amd/pi/s3_resume.c
+++ b/src/cpu/amd/pi/s3_resume.c
@@ -25,6 +25,7 @@
 #include <device/device.h>
 #include <arch/io.h>
 #include <arch/acpi.h>
+#include <program_loading.h>
 #include <string.h>
 #include "Porting.h"
 #include <northbridge/amd/pi/BiosCallOuts.h>
@@ -137,12 +138,13 @@ void restore_mtrr(void)
 #ifdef __PRE_RAM__
 static void move_stack_high_mem(void)
 {
-	void *high_stack = cbmem_find(CBMEM_ID_ROMSTAGE_RAM_STACK);
-	if (high_stack == NULL)
+	uintptr_t high_stack = romstage_ram_stack_base(HIGH_ROMSTAGE_STACK_SIZE,
+		ROMSTAGE_STACK_CBMEM);
+	if (!high_stack)
 		halt();
 
 	/* TODO: Make the switch with empty stack instead. */
-	memcpy(high_stack, (void *)BSP_STACK_BASE_ADDR, HIGH_ROMSTAGE_STACK_SIZE);
+	memcpy((void*)high_stack, (void *)BSP_STACK_BASE_ADDR, HIGH_ROMSTAGE_STACK_SIZE);
 
 #ifdef __x86_64__
 	__asm__



More information about the coreboot-gerrit mailing list