[coreboot-gerrit] New patch to review for coreboot: mainboards: remove direct acpi_slp_type usage

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Thu Jul 14 09:03:16 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15690

-gerrit

commit 76c1963b4e899ea80ace57a0864efed8043c1068
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Jul 14 01:38:31 2016 -0500

    mainboards: remove direct acpi_slp_type usage
    
    Use the acpi_is_wakeup_s3() API instead of comparing
    a raw value to a global variable. This allows for
    easier refactoring.
    
    Change-Id: I2813b5d275cbe700be713272e3a88fdb5759db99
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/cyan/ec.c  | 2 +-
 src/mainboard/google/ninja/ec.c | 2 +-
 src/mainboard/intel/strago/ec.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/cyan/ec.c b/src/mainboard/google/cyan/ec.c
index 8f516cb..cce7d70 100644
--- a/src/mainboard/google/cyan/ec.c
+++ b/src/mainboard/google/cyan/ec.c
@@ -28,7 +28,7 @@ void mainboard_ec_init(void)
 
 #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
 	/* Restore SCI event mask on resume. */
-	if (acpi_slp_type == 3) {
+	if (acpi_is_wakeup_s3()) {
 		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
 					   MAINBOARD_EC_S3_WAKE_EVENTS);
 
diff --git a/src/mainboard/google/ninja/ec.c b/src/mainboard/google/ninja/ec.c
index 994b211..147cded 100644
--- a/src/mainboard/google/ninja/ec.c
+++ b/src/mainboard/google/ninja/ec.c
@@ -26,7 +26,7 @@ void mainboard_ec_init(void)
 	post_code(0xf0);
 
 	/* Restore SCI event mask on resume. */
-	if (acpi_slp_type == 3) {
+	if (acpi_is_wakeup_s3()) {
 		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
 					   MAINBOARD_EC_S3_WAKE_EVENTS);
 
diff --git a/src/mainboard/intel/strago/ec.c b/src/mainboard/intel/strago/ec.c
index 0f8c55d..dabe274 100644
--- a/src/mainboard/intel/strago/ec.c
+++ b/src/mainboard/intel/strago/ec.c
@@ -28,7 +28,7 @@ void mainboard_ec_init(void)
 
 #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
 	/* Restore SCI event mask on resume. */
-	if (acpi_slp_type == 3) {
+	if (acpi_is_wakeup_s3()) {
 		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
 					   MAINBOARD_EC_S3_WAKE_EVENTS);
 



More information about the coreboot-gerrit mailing list