[coreboot-gerrit] New patch to review for coreboot: southbridge/intel/fsp_rangeley: use common Intel ACPI hardware definitions

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Thu Jul 14 08:13:28 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15680

-gerrit

commit 51d3090b431e2730a8ff9bda8d369998e49a8a87
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Jul 13 23:25:50 2016 -0500

    southbridge/intel/fsp_rangeley: use common Intel ACPI hardware definitions
    
    Transition to using the common Intel ACPI hardware definitions
    generic ACPI definitions.
    
    BUG=chrome-os-partner:54977
    
    Change-Id: Ia113672fa3cb740cb193c23fd06181d9ce895ac3
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/southbridge/intel/fsp_rangeley/Kconfig | 1 +
 src/southbridge/intel/fsp_rangeley/soc.h   | 9 ++-------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/southbridge/intel/fsp_rangeley/Kconfig b/src/southbridge/intel/fsp_rangeley/Kconfig
index 919d963..092cf1d 100644
--- a/src/southbridge/intel/fsp_rangeley/Kconfig
+++ b/src/southbridge/intel/fsp_rangeley/Kconfig
@@ -21,6 +21,7 @@ if SOUTHBRIDGE_INTEL_FSP_RANGELEY
 
 config SOUTH_BRIDGE_OPTIONS # dummy
 	def_bool y
+	select ACPI_INTEL_HARDWARE_SLEEP_VALUES
 	select IOAPIC
 	select HAVE_HARD_RESET
 	select HAVE_USBDEBUG
diff --git a/src/southbridge/intel/fsp_rangeley/soc.h b/src/southbridge/intel/fsp_rangeley/soc.h
index ba0fa4e..0674dca 100644
--- a/src/southbridge/intel/fsp_rangeley/soc.h
+++ b/src/southbridge/intel/fsp_rangeley/soc.h
@@ -18,6 +18,8 @@
 #ifndef SOUTHBRIDGE_INTEL_RANGELEY_SOC_H
 #define SOUTHBRIDGE_INTEL_RANGELEY_SOC_H
 
+#include <arch/acpi.h>
+
 /* SOC types */
 #define SOC_TYPE_RANGELEY	0x1F
 
@@ -316,13 +318,6 @@ void rangeley_sb_early_initialization(void);
 #define   GBL_EN	(1 << 5)
 #define   TMROF_EN	(1 << 0)
 #define PM1_CNT		0x04
-#define   SLP_EN	(1 << 13)
-#define   SLP_TYP	(7 << 10)
-#define    SLP_TYP_S0	0
-#define    SLP_TYP_S1	1
-#define    SLP_TYP_S3	5
-#define    SLP_TYP_S4	6
-#define    SLP_TYP_S5	7
 #define   GBL_RLS	(1 << 2)
 #define   BM_RLD	(1 << 1)
 #define   SCI_EN	(1 << 0)



More information about the coreboot-gerrit mailing list