[coreboot-gerrit] New patch to review for coreboot: soc/intel/skylake: don't duplicate setting ACPI sleep state

[Aaron Durbin (adurbin@chromium.org)]

Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15662

-gerrit

commit 120750d84500d47e7f7385f70d826dc16b3d61f0
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Jul 13 11:57:20 2016 -0500

    soc/intel/skylake: don't duplicate setting ACPI sleep state
    
    The ramstage main() in lib/hardwaremain.c has the logic
    to set the ACPI sleep state based on romstage_handoff. Thus,
    there's no need to do it a second time.
    
    Change-Id: I75172083587c8d4457c1466edb88d400f7ef2dd0
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/skylake/systemagent.c | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/src/soc/intel/skylake/systemagent.c b/src/soc/intel/skylake/systemagent.c
index ed02f44..819e409 100644
--- a/src/soc/intel/skylake/systemagent.c
+++ b/src/soc/intel/skylake/systemagent.c
@@ -402,32 +402,12 @@ static void systemagent_init(struct device *dev)
 	set_power_limits(28);
 }
 
-static void systemagent_enable(device_t dev)
-{
-#if CONFIG_HAVE_ACPI_RESUME
-	struct romstage_handoff *handoff;
-
-	handoff = cbmem_find(CBMEM_ID_ROMSTAGE_INFO);
-
-	if (handoff == NULL) {
-		printk(BIOS_DEBUG, "Unknown boot method, assuming normal.\n");
-		acpi_slp_type = 0;
-	} else if (handoff->s3_resume) {
-		printk(BIOS_DEBUG, "S3 Resume.\n");
-		acpi_slp_type = 3;
-	} else {
-		printk(BIOS_DEBUG, "Normal boot.\n");
-		acpi_slp_type = 0;
-	}
-#endif
-}
-
 static struct device_operations systemagent_ops = {
 	.read_resources   = &systemagent_read_resources,
 	.set_resources    = &pci_dev_set_resources,
 	.enable_resources = &pci_dev_enable_resources,
 	.init             = &systemagent_init,
-	.enable           = &systemagent_enable,
+	.enable           = DEVICE_NOOP,
 	.ops_pci          = &soc_pci_ops,
 };