[coreboot-gerrit] Patch merged into coreboot/master: soc/intel/apollolake: provide gpio _HIGH/_LOW macros

gerrit at coreboot.org gerrit at coreboot.org
Wed Jul 13 21:57:52 CEST 2016


the following patch was just integrated into master:
commit a277bacd56ff04e5b9818dd4913708fb85a8d8d8
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Jul 12 16:46:20 2016 -0500

    soc/intel/apollolake: provide gpio _HIGH/_LOW macros
    
    Internally, apollolake routes its interrupts as active high.
    This includes SCI, SMI, and ACPI. Therefore, provide helper
    macros such that the user can describe an interrupt's active
    high/low polarity more easily. It helps for readability when
    one is comparing gpio configuration next to APIC configuration
    in different files. Additionally, the gpio APIC macros always
    use a LEVEL trigger in order to let the APIC handle the
    filtering of the IRQ on its own end.
    
    BUG=chrome-os-partner:54977
    
    Change-Id: Id8fdcd98f0920936cd2b1a687fd8fa07bce9a614
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/15644
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Furquan Shaikh <furquan at google.com>
    Reviewed-by: Andrey Petrov <andrey.petrov at intel.com>


See https://review.coreboot.org/15644 for details.

-gerrit



More information about the coreboot-gerrit mailing list