[coreboot-gerrit] Patch set updated for coreboot: FSP1_0 does not support HAVE_ACPI_RESUME
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Wed Jul 13 12:05:30 CEST 2016
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15576
-gerrit
commit 6a32b33f6cb830952d05ba57d4d0476fcd9db378
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Tue Jul 5 09:41:59 2016 +0300
FSP1_0 does not support HAVE_ACPI_RESUME
FSP1_0 places romstage ram stack at fixed location of
RAMTOP in low memory before returning to coreboot proper.
There is no possibility of making a complete backup of
RAMBASE..RAMTOP region and currently such backup is not
even attempted.
As a conclusion, S3 resume would always cause OS memory
corruption.
Change-Id: I5b9dd4069082e022b01b0d6a9ad5dec28a06e8b0
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
src/mainboard/esd/atom15/Kconfig | 1 -
src/mainboard/intel/minnowmax/Kconfig | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/mainboard/esd/atom15/Kconfig b/src/mainboard/esd/atom15/Kconfig
index 3f4b76b..814177e 100644
--- a/src/mainboard/esd/atom15/Kconfig
+++ b/src/mainboard/esd/atom15/Kconfig
@@ -23,7 +23,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_ACPI_TABLES
select HAVE_OPTION_TABLE
select TSC_MONOTONIC_TIMER
- select HAVE_ACPI_RESUME
config MAINBOARD_DIR
string
diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig
index 2f23270..f0c4526 100644
--- a/src/mainboard/intel/minnowmax/Kconfig
+++ b/src/mainboard/intel/minnowmax/Kconfig
@@ -23,7 +23,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_ACPI_TABLES
select HAVE_OPTION_TABLE
select TSC_MONOTONIC_TIMER
- select HAVE_ACPI_RESUME
config MAINBOARD_DIR
string
More information about the coreboot-gerrit
mailing list