[coreboot-gerrit] New patch to review for coreboot: AMD k8 fam10: Drop excessive spinlock initialization

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Fri Jul 8 20:58:09 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15589

-gerrit

commit 2f76cf64147e2045b718dad2dff1560181e9f77f
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jul 8 11:35:45 2016 +0300

    AMD k8 fam10: Drop excessive spinlock initialization
    
    If CAR migration operations unintentionally set the lock,
    BSP would have got stuck on printk() calls above already.
    
    Change-Id: I35155ebcb00475a0964fc639ee74ad2755127740
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/amd/car/post_cache_as_ram.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/cpu/amd/car/post_cache_as_ram.c b/src/cpu/amd/car/post_cache_as_ram.c
index ed0a3a5..bf27212 100644
--- a/src/cpu/amd/car/post_cache_as_ram.c
+++ b/src/cpu/amd/car/post_cache_as_ram.c
@@ -94,13 +94,6 @@ static void prepare_ramstage_region(int s3resume)
 		memset_((void*)0, 0, CONFIG_RAMTOP - backup_top);
 	}
 
-#if IS_ENABLED(CONFIG_HAVE_ROMSTAGE_CONSOLE_SPINLOCK)
-	initialize_romstage_console_lock();
-#endif
-#if IS_ENABLED(CONFIG_HAVE_ROMSTAGE_NVRAM_CBFS_SPINLOCK)
-	initialize_romstage_nvram_cbfs_lock();
-#endif
-
 	print_car_debug(" Done\n");
 }
 



More information about the coreboot-gerrit mailing list