[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: make internal pulls weak for gpio inputs
Aaron Durbin (adurbin@chromium.org)
gerrit at coreboot.org
Thu Jul 7 05:57:19 CEST 2016
Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15558
-gerrit
commit 5beb28b345529f5a17157a87e5e7fb86d7e6ee66
Author: Aaron Durbin <adurbin at chromium.org>
Date: Wed Jul 6 22:41:24 2016 -0500
soc/intel/apollolake: make internal pulls weak for gpio inputs
The internal pulls for gpio_input_pullup() and gpio_input_pulldown()
were using fairly strong pulls. Weaken them so that external pulls
can override the internal ones. This matches the current assumptions
of lib/gpio.c.
BUG=chrome-os-partner:54949
BRANCH=None
TEST=Built and used on reef for memory config.
Change-Id: Ifda1d04d40141325f78db277eb0bd55574994abf
Signed-off-by: Aaron Durbin <adurbin at chromuim.org>
---
src/soc/intel/apollolake/gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c
index 525c972..699c8fe 100644
--- a/src/soc/intel/apollolake/gpio.c
+++ b/src/soc/intel/apollolake/gpio.c
@@ -71,13 +71,13 @@ void gpio_configure_pads(const struct pad_config *cfg, size_t num_pads)
void gpio_input_pulldown(gpio_t gpio)
{
- struct pad_config cfg = PAD_CFG_GPI(gpio, DN_5K, DEEP);
+ struct pad_config cfg = PAD_CFG_GPI(gpio, DN_20K, DEEP);
gpio_configure_pad(&cfg);
}
void gpio_input_pullup(gpio_t gpio)
{
- struct pad_config cfg = PAD_CFG_GPI(gpio, UP_5K, DEEP);
+ struct pad_config cfg = PAD_CFG_GPI(gpio, UP_20K, DEEP);
gpio_configure_pad(&cfg);
}
More information about the coreboot-gerrit
mailing list